[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 18:19:09 PDT 2011


--- Comment #36 from Alexis Menard <alexis.menard at openbossa.org>  2011-08-23 18:19:08 PST ---
(From update of attachment 104947)
View in context: https://bugs.webkit.org/attachment.cgi?id=104947&action=review

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:41
> +    : q(q ? q : new QDesktopWebView(contextRef, pageGroupRef))

Very wrong change. This case should never happen, Qt coding practices to create private object should be respected, you create the private object from the public and it's linked to it, you can't create private object itself alone.

> Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:46
> +    m_inspectorView = new QDesktopWebViewPrivate(0, toAPI(page()->process()->context()), toAPI(inspectorPageGroup()));

See comment below, you can't create the private without its public object.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list