[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 18:08:41 PDT 2011


Alexis Menard <alexis.menard at openbossa.org> changed:

           What    |Removed                     |Added
 Attachment #104947|review?                     |review-
               Flag|                            |

--- Comment #35 from Alexis Menard <alexis.menard at openbossa.org>  2011-08-23 18:08:40 PST ---
(From update of attachment 104947)
View in context: https://bugs.webkit.org/attachment.cgi?id=104947&action=review

> Source/WebKit2/ChangeLog:17
> +        (WebKit::WebInspectorProxy::didLoadInspectorPage): RequestAttachWindow() not exist. Commented.

Regenerate your changelog after removing commented code.

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:223
> +    inspectorPage->loadURL(inspectorPageURL());

Why this change?

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:235
> +//        m_page->process()->send(Messages::WebInspector::RequestAttachWindow(), m_page->pageID());

You can't commit that.

> Source/WebKit2/UIProcess/WebInspectorProxy.h:183
> +    QSGView* m_view;

I think you can use OwnPtr here.

> Source/WebKit2/UIProcess/WebInspectorProxy.h:184
> +    QDesktopWebViewPrivate* m_inspectorView;

I don't understand why it needs to be a QDesktopWebViewPrivate unless I miss something.

> Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:38
> +class QObject;

You don't forward declare class in a cpp object.

> Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:58
> +    m_view = new QSGView();

This seems to leak.

> Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:68
> +        delete m_inspectorView->q;

What is that? This is very wrong programming methods.

> Tools/MiniBrowser/qt/BrowserView.cpp:35
> +#include <qdesktopwebview_p.h>

This is not acceptable. You can't use private API.

> Tools/MiniBrowser/qt/BrowserView.cpp:100
> +        QDesktopWebViewPrivate* desktopWebViewPrivate = new QDesktopWebViewPrivate(desktopWebView()); 

This is wrong. You can't create private object like this.

> Tools/MiniBrowser/qt/BrowserView.cpp:112
> +        delete desktopWebViewPrivate;

This is very wrong to me. You shouldn't do that at all. Have you look how the API looks like in WebKit1, we should aim for something easy, this is WAY too complicated to use and requires private API and some hacks.

> Tools/MiniBrowser/qt/MiniBrowser.pro:23
> +include(../../../Source/WebKit2/WebKit2.pri)

Why this?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list