[Webkit-unassigned] [Bug 23200] Upstream more platform/graphics/skia files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23200





--- Comment #11 from John Bates <jbates at google.com>  2011-08-23 17:46:21 PST ---
(From update of attachment 26547)
View in context: https://bugs.webkit.org/attachment.cgi?id=26547&action=review

> WebCore/platform/graphics/skia/NativeImageSkia.h:40
> +class NativeImageSkia : public SkBitmap {

Hrm.. this may not be safe. SkBitmap has a non-virtual destructor and it uses dangerous tricks in its operator= implementation that may clobber derived class members depending on alignment. (When a class derives from a non-POD object, its members can reside inside the sizeof its parent class.) Looks like this may be related to a memory leak bug https://bugs.webkit.org/show_bug.cgi?id=66488 and possibly other random bugs unless we've been lucky. Anyhoo, I'm attempting to make SkBitmap a member rather than deriving from it. It would be great if we could instrument classes such as this so that it would be a compiler warning/error to derive from them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.