[Webkit-unassigned] [Bug 66788] [chromium] Make WebGL context current before querying for extensions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 17:13:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66788





--- Comment #9 from Kenneth Russell <kbr at google.com>  2011-08-23 17:13:03 PST ---
(From update of attachment 104910)
View in context: https://bugs.webkit.org/attachment.cgi?id=104910&action=review

After our offline discussion I'm strongly inclined to push the necessary makeContextCurrent() calls into the implementation, which should reduce this patch to a one-liner. What do you think?

> Source/WebKit/chromium/src/GraphicsContext3DInternal.h:338
> +    bool m_makeContextCurrentWasCalled;

As the comment indicates, this bool is fragile and doesn't handle multiple contexts per thread. Per our offline discussion, it sounds like the better direction for GraphicsContext3D is to make it easier to use, i.e., assume that makeContextCurrent() is called implicitly for each of its other entry points. That will also simplify this patch.

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:801
> +    ASSERT(m_makeContextCurrentWasCalled);

Let's just call makeContextCurrent() here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list