[Webkit-unassigned] [Bug 66814] [chromium] Renderer crashes when about:gpucrash is loaded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66814





--- Comment #3 from Iain Merrick <husky at google.com>  2011-08-23 16:58:44 PST ---
(From update of attachment 104924)
View in context: https://bugs.webkit.org/attachment.cgi?id=104924&action=review

>> Source/WebKit/chromium/src/WebViewImpl.cpp:2667
>> +    setIsAcceleratedCompositingActive(success);
> 
> why is this different from the previous logic?
> 
> looks like you broke page overlays here, any particular reason to change that logic too?

setRootGraphicsLayer was calling setIsAcceleratedCompositingActive, in addition to the stuff that was causing the crash.

It looked to me like the page overlay update was redundant, because that is called on line 2628 inside setIsAcceleratedCompositingActive, but that only happens if m_layerTreeHost is null. So you're right, it's still needed here -- I'll add it back in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.