[Webkit-unassigned] [Bug 66747] There is no facility for profiling how the write barrier is used

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66747


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104902|review?                     |review+
               Flag|                            |




--- Comment #7 from Geoffrey Garen <ggaren at apple.com>  2011-08-23 16:00:13 PST ---
(From update of attachment 104902)
View in context: https://bugs.webkit.org/attachment.cgi?id=104902&action=review

r=me, but you have a minor bug here in the ENABLE(GGC) case to fix.

> Source/JavaScriptCore/heap/Heap.h:253
>      inline void Heap::writeBarrier(const JSCell* owner, JSValue value)
>      {
> +        WriteBarrierCounters::countWriteBarrier();
>          if (!value)
>              return;
>          if (!value.isCell())

Since this version of Heap::writeBarrier calls through to the JSCell* version, you'll double-count cases where you don't early return. You need to call WriteBarrierCounters::countWriteBarrier() inside each early return, and not in the body of the function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.