[Webkit-unassigned] [Bug 66531] Don't detach elements from the render tree when entering fullscreen mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66531


Jeremy Apthorp <jeremya at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104784|1                           |0
        is obsolete|                            |




--- Comment #16 from Jeremy Apthorp <jeremya at chromium.org>  2011-08-23 15:18:41 PST ---
(From update of attachment 104784)
View in context: https://bugs.webkit.org/attachment.cgi?id=104784&action=review

>> Source/WebCore/rendering/RenderFullScreen.cpp:101
>> +    fullscreenStyle->setTop(Length(0, WebCore::Fixed));
> 
> I'm curious why this is necessary, given the "using namespace WebCore;" directive above.

It's ambiguous with 'typedef SInt32 Fixed' in a system header (MacTypes.h) if I don't include the namespace resolution.

>> Source/WebCore/rendering/RenderFullScreen.cpp:133
>> +        parent->addChild(wrappedRenderer, holder);
> 
> You null-check wrappedRenderer before calling remove(), but not before passing wrappedRenderer to parent->addChild().  It appears it's not safe to pass a null value into that function (see RenderObject.cpp), so the second if statement should check wrappedRenderer as well.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.