[Webkit-unassigned] [Bug 66664] [Qt][WK2] Add the animations on the ViewportInteractionEngine

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66664





--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-08-23 15:05:03 PST ---
(From update of attachment 104891)
View in context: https://bugs.webkit.org/attachment.cgi?id=104891&action=review

> Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:208
> +void ViewportInteractionEngine::emitContentGeometryChangedWithCurrentGeometry()

current viewport geometry? That name is a big mouthful :-)

Anyway, you are using this in two places only and it might be more clear to actually just have the code there. Then noone will be in doubt about the coord system.

> Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:282
> -void ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded()
> +void ViewportInteractionEngine::animateContentIntoBoundariesIfNeeded()

So they had to be joined after all?

> Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:289
> +    const qreal boundedScale = qBound(m_constraints.minimumScale, currentScale, m_constraints.maximumScale);

Can't you copy our innerBound and outerBound methods from the N9 browser? We are bound to use these in more places and we are going to allow zooming a bit further out than the min scale for instance and then showing a bouncing back animation.

> Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:299
> +        // Revert the change in order to animated both the scale and position.

Something wrong with the English here. I guess you mean 'animate'

> Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:338
> +        // Already commit final visible rect so new tiles can already be rendered.

two already's in there. // Commit the final visible rect already now, so that new tiles can be rendered immediately  ??

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.