[Webkit-unassigned] [Bug 66081] The "port" property of an <a> whose href does not specify a port returns the wrong value

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 14:39:18 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66081


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104916|review?                     |review+
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2011-08-23 14:39:18 PST ---
(From update of attachment 104916)
View in context: https://bugs.webkit.org/attachment.cgi?id=104916&action=review

I feel like I get in trouble whenever I review these sorts of patches, but this patch seems good.

> Source/WebCore/html/HTMLAnchorElement.cpp:409
> +    return String("");

You can just return "" or emptyString().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list