[Webkit-unassigned] [Bug 66747] There is no facility for profiling how the write barrier is used

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66747


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104801|review?                     |review-
               Flag|                            |




--- Comment #5 from Geoffrey Garen <ggaren at apple.com>  2011-08-23 11:20:33 PST ---
(From update of attachment 104801)
View in context: https://bugs.webkit.org/attachment.cgi?id=104801&action=review

Looks good, but I think the C++ counter is not quite right.

> Source/JavaScriptCore/runtime/WriteBarrier.h:151
>      // when some basic types aren't yet completely instantiated
>      void setEarlyValue(JSGlobalData&, const JSCell* owner, T* value)
>      {
> +#if ENABLE(WRITE_BARRIER_PROFILING)
> +        WriteBarrierCounters::usesWithBarrierFromCpp.count();
> +#endif
>          this->m_cell = reinterpret_cast<JSCell*>(value);
>          Heap::writeBarrier(owner, this->m_cell);

I think you want to put the counter inside Heap::writeBarrier, and not setEarlyValue. Heap::writeBarrier is the central funnel that will catch all C++ access.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.