[Webkit-unassigned] [Bug 66788] [chromium] Make WebGL context current before querying for extensions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66788


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104867|review?                     |review-
               Flag|                            |




--- Comment #2 from James Robinson <jamesr at chromium.org>  2011-08-23 11:19:29 PST ---
(From update of attachment 104867)
View in context: https://bugs.webkit.org/attachment.cgi?id=104867&action=review

This patch is rooted at the wrong dir - it should be rooted at the root of the repo, so the paths show up as Source/WebCore/... - it looks like this is rooted inside the Source/ directory.  This means that the show more context links don't work in the review tool.

> WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You can't commit with this message, there's an svn presubmit hook that will reject it.  Please explain how to test this (I think you can exercise this by flipping some local define, right?)

> WebCore/html/canvas/WebGLRenderingContext.cpp:387
> +    m_context->makeContextCurrent();

it would make more sense to me to do this in setupFlags(), closer to where we actually use the context.

Do we need to do the same thing in WebGLRenderingContext::maybeRestoreContext() ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.