[Webkit-unassigned] [Bug 65834] NRWT should support cascading expectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 10:37:43 PDT 2011


--- Comment #17 from Dirk Pranke <dpranke at chromium.org>  2011-08-23 10:37:42 PST ---
(In reply to comment #16)
> > BUGX MAC : foo/bar.html = PASS
> > 
> > and a line in the regular file like:
> > 
> > BUGY WIN : foo/bar.html = TEXT
> In this example the next line is the correct?
> BUGY WIN : foo/bar.html = TEXT

They are both correct. Imagine we're talking about the Qt port here. One expectation might be intended for the webkit2 version of qt-mac, and the other for qt-win (could be either for webkit1 or for both webkit1 and webkit2).

> But I think it is a very bad idea to write an expected line like this in the file what is for the cross-platform failures.

The basic idea of the test expectations file is to be able to manage all of the expectations for a single port in a single file; this is different than what we do using Skipped files, where you have files for each platform (and version, in some cases).

If you wanted to have a file represent only cross-platform failures, and another file represent failures specific to a single platform (or version), we could do that, but that would be a change from what the code does now (I wouldn't really be in favor of this change, in case that wasn't obvious).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list