[Webkit-unassigned] [Bug 66681] Need API for getting surrounding text from webkit in chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 10:33:18 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66681





--- Comment #10 from Tony Chang <tony at chromium.org>  2011-08-23 10:33:18 PST ---
(From update of attachment 104692)
View in context: https://bugs.webkit.org/attachment.cgi?id=104692&action=review

Since the file is in the webkit repo, we should follow the webkit coding style.  Fitting into 80 cols does not violate the webkit coding style.

This file has a mix of styles, but we should try to write new code using webkit style.

> Source/WebKit/chromium/ChangeLog:4
> +        Add API for getting surrounding text from webkit in chromium
> +        https://bugs.webkit.org/show_bug.cgi?id=66681

Please explain why this you need this in the changelog (copying the text from comment #0 would be sufficient).

> Source/WebKit/chromium/src/WebViewImpl.cpp:1541
> +    // TODO truncate the text into reansonable size

WebKit style uses FIXME rather than TODO.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list