[Webkit-unassigned] [Bug 66681] Need API for getting surrounding text from webkit in chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66681


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbono at chromium.org,
                   |                            |tony at chromium.org




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-08-23 10:13:21 PST ---
(In reply to comment #5)
> For coding style, I think the code is in webkit, probably it is better to follow webkit coding guideline? And I also find some functions use mutable reference in this header file. I am confused.

Mn... it appears to me WebViewImpl.cpp follows Chromium coding convention but I can be wrong. Darin probably knows what we should be doing here.

> >> Source/WebKit/chromium/src/WebViewImpl.cpp:1512
> >> +bool WebViewImpl::surrounding(WebString& text, size_t& cursor, size_t& anchor)
> > 
> > It's sad to have this logic in WebKit layer.
> > If we have this in WebCore and make it available from LayoutTestcontroller or window.internals, It can be testable
> > and also would be helpful for other ports.
> 
> Could you give more detail information? So I could look into it.

The logic to extract surrounding text exists in many WebKit ports.  I'm actually surprised that we don't already have a logic to do this for IME.

> Probably those code is in webkit repo. It should follow webkit coding guideline. For example indent is 2 spaces in chrome, but here is 4 spaces.

That's true.  But most of lines in that file appear to fit in 80-characters.  So I'm a bit confused here as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.