[Webkit-unassigned] [Bug 64290] The layout of RenderBox should be calculated using fixedLayoutSize instead of viewport when the fixedLayoutSize is set.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64290





--- Comment #7 from Young Han Lee <joybro at company100.net>  2011-08-23 09:34:26 PST ---
(In reply to comment #6)
> > No. layoutController.overridePreference() is not helpful because it toggles only settings of WebSettings.
> > 
> > To turn on the fixedLayoutSize feature, to test this patch, FrameView::setUseFixedLayout(true) have to be called.
> > 
> > I think there is no easy way to turn on this feature for a single test.
> 
> It raises an interesting point. I do not think it should be necessary to set the fixedLayoutSize and set useFixedLayoutSize to TRUE.
> 
> Maybe once it is set to something different than 0x0, it should be used.
> 
> There could be a logicalLayoutSize in ScrollView that abstracts this for the call sites.
> 
> IntSize ScrollView::logicalLayoutSize() const
> {
>   if (m_fixedLayoutSize.isValid()) // != 0x0, and has non zero values
>     return m_fixedLayoutSize;
> 
>   return viewportSize;
> }

Here is the implementation of the layoutWidth().

int ScrollView::layoutWidth() const
{
    return m_fixedLayoutSize.isEmpty() || !m_useFixedLayout ? visibleWidth() : m_fixedLayoutSize.width();
}

As you can see, m_fixedLayoutSize is not returned, even if it isn't empty, when m_useFixedLayout is not TRUE.

Unfortunately there is also no function like you said in ScrollView. For now, we have to set both fixedLayoutSize and useFixedLayoutSize.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.