[Webkit-unassigned] [Bug 66707] Chromium Mac: Use a custom pattern image for rubber banding overhang area

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66707





--- Comment #6 from Nico Weber <thakis at chromium.org>  2011-08-23 00:53:24 PST ---
(From update of attachment 104731)
View in context: https://bugs.webkit.org/attachment.cgi?id=104731&action=review

LGTM

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:198
> +        Image* patternImage = Image::loadPlatformResource("overhangPattern").releaseRef();

releaseRef() documentation says "        // FIXME: Remove releaseRef once we change all callers to call leakRef instead.", so do you want to call leakRef() here?

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:199
> +        m_overhangPattern = Pattern::create(patternImage, true, true);

Looks like create() takes a PassRefPtr, so maybe you don't even need the leakRef() call. I'm not sure if http://www.webkit.org/coding/RefPtr.html recommends against that or not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.