[Webkit-unassigned] [Bug 66523] [chromium] RenderView should register for WebGraphics3D callbacks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66523


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104518|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #8 from James Robinson <jamesr at chromium.org>  2011-08-22 20:14:03 PST ---
(From update of attachment 104518)
View in context: https://bugs.webkit.org/attachment.cgi?id=104518&action=review

Seems reasonable.  Where's the chromium side?

Given how many callbacks we have now (lost context, swapbuffers complete, swapbuffers posted, etc etc) I wonder if it's time to move to a more general interface for this sort of thing.

> WebKit/chromium/ChangeLog:18
> +        * public/WebGraphicsContext3D.h:
> +        (WebKit::WebGraphicsContext3D::WebGraphicsSwapBuffersPostedCallbackCHROMIUM::~WebGraphicsSwapBuffersPostedCallbackCHROMIUM):
> +        (WebKit::WebGraphicsContext3D::setSwapBuffersPostedCallbackCHROMIUM):
> +        * public/WebViewClient.h:
> +        (WebKit::WebViewClient::initCompositorContext):
> +        * src/WebViewImpl.cpp:
> +        (WebKit::WebViewImpl::createLayerTreeHostContext3D):
> +        (WebKit::WebViewImpl::graphicsContext3D):

This is out of date, please regenerate (or just edit).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.