[Webkit-unassigned] [Bug 66531] Don't detach elements from the render tree when entering fullscreen mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66531





--- Comment #12 from Jeremy Apthorp <jeremya at chromium.org>  2011-08-22 19:14:06 PST ---
(From update of attachment 104645)
View in context: https://bugs.webkit.org/attachment.cgi?id=104645&action=review

>> Source/WebCore/ChangeLog:7
>> +        when entering fullscreen mode.
> 
> Then there should be a test demonstrating this.

Done.

>> Source/WebCore/rendering/RenderFullScreen.cpp:114
>> +        if (parent) {
> 
> I think this can be written as:
> 
> if (RenderObject* parent = object->parent()) {

Done.

>> Source/WebCore/rendering/RenderFullScreen.h:50
>> +    RenderObject* m_wrappedRenderer;
> 
> The wrapped renderer will always be the first and only child of the RenderFullScreen, so this extra ivar is probably unnecessary.  All the instances above which reference m_wrappedRenderer can be replaced with firstChild().

Done.

>> Source/WebCore/rendering/RenderFullScreen.h:51
>> +    static PassRefPtr<RenderStyle> createFullScreenStyle();
> 
> If this is only ever accessed from RenderFullScreen.cpp now, it can be made a file static.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.