[Webkit-unassigned] [Bug 66571] Keep track of topCallFrame for Stack traces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66571





--- Comment #12 from Juan C. Montemayor <jmont at apple.com>  2011-08-22 16:42:34 PST ---
> > Source/JavaScriptCore/interpreter/Interpreter.cpp:711
> >      CodeBlock* codeBlock = callFrame->codeBlock();
> >      bool isInterrupt = false;
> > +    callFrame->globalData().topCallFrame = callFrame;
> 
> Why does the first act of throwing an exception need to be to set topCallFrame? 

in throwException(), addErrorInfo() needs the updated callFrame to work properly. I update the topCallFrame before the first if statement to set it in case it branches.

> On the other hand, I think you're missing an update of topCallFrame after you've thrown an exception and decided to return to a handler. You can put the update into unwindCallFrame().

If I only update the callFrame inside unwindCallFrame, my code would fail jsc-tests. As I mentioned before, addErrorInfo() needs the updated callFrame to work, and addErrorInfo() is called before unwindCallFrame()

Should I keep it like this or what would be the right course of action?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.