[Webkit-unassigned] [Bug 66720] chromium WebFrameImpl - don't load javascript URLs against chrome internal pages.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 22 15:46:36 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66720





--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-08-22 15:46:36 PST ---
(From update of attachment 104751)
View in context: https://bugs.webkit.org/attachment.cgi?id=104751&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:2291
> +    // Protect privileged pages against bookmarklets and other javascript
> +    // manipulations.
> +    if (m_frame->document()->url().protocolIs("chrome")
> +        || m_frame->document()->url().protocolIs("chrome-extension"))
> +        return;

We shouldn't have these string literals in this code.  Isn't there something in SchemeRegistry we could use?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list