[Webkit-unassigned] [Bug 65470] [Qt] libwebcore.a source is compiled without -fvisibility=hidden -fvisibility-inlines-hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65470





--- Comment #9 from Ademar Reis <ademar.reis at openbossa.org>  2011-08-22 07:36:19 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #1)
> > > Created an attachment (id=103173)
 --> (https://bugs.webkit.org/attachment.cgi?id=103173&action=review) [details] [details] [details]
> > > Example to re-enable visibility
> > > 
> > > This patch depends on #27551 introducing USE(EXPORT_MACROS) which would fix this but would normally also export more symbols than we want/need for Qt.
> > 
> > Holger: The latest patch attached to bug 27551 doesn't contain any references to EXPORT_MACROS. Are you sure it's still needed? Regarding WebKit1 (QtWebKit-2.2), would it make sense to land your patch AS IS?
> 
> Export macros landed as part of r81135 but are turned off on the transition phase.

So my understanding is that the only thing currently blocking this for trunk is bug 65826 (which is WK2 related). In other words, it could be applied to 2.2 AS IS, right?

(I'm not saying I want to apply it, just asking if there's anything missing)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.