[Webkit-unassigned] [Bug 66628] [Qt] QWebSpellChecker plugins crash webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66628


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104627|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Benjamin Poulain <benjamin at webkit.org>  2011-08-21 06:21:44 PST ---
(From update of attachment 104627)
The patch seems to be the correct fix but the Changelog  is not correctly formatted.

It should be:

-title
-url

-reviewer line

-description

-changelist with more description if necessary.
----
The description could also be better. Something briefly explaining the bug e.g.:
"The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the plugin at the end of the scope.

This patch moves the local creation of QtPlatformPlugin to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading of plugin."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.