[Webkit-unassigned] [Bug 66571] Keep track of topCallFrame for Stack traces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66571





--- Comment #6 from Darin Adler <darin at apple.com>  2011-08-19 16:11:53 PST ---
(From update of attachment 104559)
View in context: https://bugs.webkit.org/attachment.cgi?id=104559&action=review

> Source/JavaScriptCore/interpreter/CallFrame.h:166
> +    class TopCallFrame {

I don’t think the class name here is right. It should be something like TopCallFrameSetter.

Since this class is only used in three places in Interpreter.cpp I think it shouldn’t go into CallFrame.h. It can go into Interpreter.cpp.

> Source/JavaScriptCore/interpreter/CallFrame.h:168
> +        TopCallFrame(JSGlobalData* global, CallFrame* callFrame)

I suggest taking a reference to global data instead of a pointer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.