[Webkit-unassigned] [Bug 65277] Make functions to find word boundaries more flexible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65277





--- Comment #46 from Van Lam <vanlam at google.com>  2011-08-19 16:07:50 PST ---
(In reply to comment #44)
> (From update of attachment 104432 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104432&action=review
> 
> > Source/WebCore/editing/visible_units.cpp:1601
> > +    if (currentOffset > startingOffset)
> 
> should we checking (currentBox == startingBox &&....)?
> 
> > Source/WebCore/editing/visible_units.cpp:1624
> > +        return prevNext;
> 
> ditto

If we exit early because of this check then (In reply to comment #44)
> (From update of attachment 104432 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104432&action=review
> 
> > Source/WebCore/editing/visible_units.cpp:1601
> > +    if (currentOffset > startingOffset)
> 
> should we checking (currentBox == startingBox &&....)?
> 
> > Source/WebCore/editing/visible_units.cpp:1624
> > +        return prevNext;
> 
> ditto

Right. I didn't catch this as the return values of these two functions are checked using positionIsInBoxButNotOnBoundary right after being called. But we should never return a position outside of startingBox to be safe. I'll resubmit with the additional check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.