[Webkit-unassigned] [Bug 65834] NRWT should support cascading expectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 19 15:58:38 PDT 2011


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #104311|review?                     |review-
               Flag|                            |

--- Comment #15 from Dirk Pranke <dpranke at chromium.org>  2011-08-19 15:58:37 PST ---
(From update of attachment 104311)
View in context: https://bugs.webkit.org/attachment.cgi?id=104311&action=review

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:370
> +        return result

I'm pretty sure that by coding things this way you're ignoring any modifiers that might be set on the lines, and so if you have a line in the wk2 file like:

BUGX MAC : foo/bar.html = PASS

and a line in the regular file like:

BUGY WIN : foo/bar.html = TEXT

you will throw away the second line, which would be wrong.

I'm not sure that trying to manually implement a cascade through concatenation and a limited form of deduplication is a fruitful way of doing things. I think we probably need to implement "proper" support for cascading that is aware of the modifiers.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list