[Webkit-unassigned] [Bug 62168] error: converting 'false' to pointer type when compiling with gcc-4.6.0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62168





--- Comment #30 from Darin Adler <darin at apple.com>  2011-08-19 13:27:12 PST ---
(From update of attachment 104545)
View in context: https://bugs.webkit.org/attachment.cgi?id=104545&action=review

> Source/WebCore/dom/ContainerNode.cpp:764
> +bool ContainerNode::hasStyle() const

Thanks for doing what I asked. Style-wise this is way better. Since this code is quite hot, I think we probably want to make sure this is inlined. It’s slightly tricky to do that because we can’t put it in ContainerNode.h. Sorry, this is getting unpleasantly complicated. I guess we can try with it not inlined, but I do fear this will make things slower.

> Source/WebCore/dom/ContainerNode.cpp:766
> +    if (renderer()->style())

What guarantees the renderer is non-zero? I think we need to check that too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.