[Webkit-unassigned] [Bug 66571] Keep track of topCallFrame for Stack traces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66571


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104538|review?                     |review-
               Flag|                            |




--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2011-08-19 12:53:29 PST ---
(From update of attachment 104538)
View in context: https://bugs.webkit.org/attachment.cgi?id=104538&action=review

> Source/JavaScriptCore/runtime/JSObject.h:433
>  inline JSObject* asObject(JSValue value)
>  {
> +    if (!value.isCell())
> +        return 0;
>      return asObject(value.asCell());

This change is no good. No code should call asObject on a value if the value is not a cell (and therefore not an object). It's akin to a bad C++ cast.

Is this change required to make your patch work?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.