[Webkit-unassigned] [Bug 66548] check-webkit-style should allow out RefPtr parameters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66548





--- Comment #4 from Darin Adler <darin at apple.com>  2011-08-19 10:21:01 PST ---
(In reply to comment #3)
> I think other parts of the code would write that as a reference instead of a pointer. Or they'd return a PassRefPtr from the method itself.

Yes.

> Also, "get" is not normally used in method names, except where dictated by the DOM api.

I disagree; get is correctly used here to indicate a function that uses an out argument rather than a function result.

But as Eric says, in this case there is no obvious reason for use of an out argument for a single function result. Returning a PassRefPtr is the idiom for this sort of thing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.