[Webkit-unassigned] [Bug 66531] Don't detach elements from the render tree when entering fullscreen mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66531





--- Comment #6 from Jer Noble <jer.noble at apple.com>  2011-08-19 07:47:37 PST ---
(From update of attachment 104453)
View in context: https://bugs.webkit.org/attachment.cgi?id=104453&action=review

> Source/WebCore/dom/Document.cpp:4820
> +    if (m_fullScreenElement != documentElement()) {
> +        RenderFullScreen* fullscreenRenderer = new (renderArena()) RenderFullScreen(this);
> +        fullscreenRenderer->setStyle(RenderFullScreen::createFullScreenStyle());
> +        fullscreenRenderer->wrapRenderer(renderer);
> +        setFullScreenRenderer(fullscreenRenderer);
> +    }

This is mostly duplicating existing code in NodeRenderingContext.cpp: wrapWithRenderFullScreen(...).

> Source/WebCore/rendering/RenderFullScreen.cpp:114
> +void RenderFullScreen::wrapRenderer(RenderObject* renderer)
> +{
> +    RenderObject* parent = renderer->parent();
> +    parent->addChild(this, renderer);
> +    renderer->remove();
> +    addChild(renderer);
> +}

As is this.  Perhaps that function could be promoted to a public class method or moved into RenderFullScreen.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.