[Webkit-unassigned] [Bug 64880] Controls not reset when media element url changed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 19 07:05:18 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64880


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104506|review?                     |review-
               Flag|                            |




--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2011-08-19 07:05:18 PST ---
(From update of attachment 104506)
Thanks for picking this up!


View in context: https://bugs.webkit.org/attachment.cgi?id=104506&action=review

> Source/WebCore/ChangeLog:7
> +
> +

Nit: The extra blank line is not necessary.


> Source/WebCore/manual-tests/media-controls-invalid-url.html:6
> +      function setMovie(index)

Evil, evil tabs!


> Source/WebCore/manual-tests/media-controls-invalid-url.html:28
> +  <p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=64880">https://bugs.webkit.org/show_bug.cgi?id=64880</a><br>
> +    Media element controls are not reset to their default state when the src is changed.</p>
> +  <video id="vid" height=480 type="video/mp4"
> +         src="../../../LayoutTests/media/content/test.mp4"
> +         controls>
> +  </video>
> +  <br>
> +  <div onclick="setMovie('1')" >Valid url</div>
> +  <div onclick="setMovie('0')" >Invalid url</div>

This should be made into an automated layout test. Manual tests aren't run very often so the things they test for can regress - e.g.. https://bugs.webkit.org/show_bug.cgi?id=66303. 

Making this into an automated test should be easy, I would start out with a valid url and change to an invalid one in a 'canplaythrough' event listener. 

It should be possible to be make the results platform agnostic, despite the fact that ports have different control layout, by checking for the presence of the slider with the shadow DOM API (look for other tests in media/ tests that use media-controls.js).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list