[Webkit-unassigned] [Bug 65408] [EFL] Add "return" statement corresponding to abnormal condition on _ewk_frame_smart_add.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65408





--- Comment #13 from KwangHyuk <hyuki.kim at samsung.com>  2011-08-19 06:10:30 PST ---
> I think this could be stated a little more clearly. Something like: Bail out when we fail to allocate an Ewk_Frame_Smart_Data object rather than continuing on as if the allocation had succeeded.

Great sentence and I will update it according to your idea. :-)

> Is this really a condition we expect to occur? Will we really continue to function correctly even if we return early from this function? We don't check for allocation failures in most of WebKit/WebCore, so I assume that if we're really in an out-of-memory situation we'll just crash a little later.

I agree with you that crash may be the better way to detect the error condition faster.
But, I believe that we will be able to notice the critical error message as soon as it will occur and this patch will give more time which browser can be alive little longer. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.