[Webkit-unassigned] [Bug 66286] Use String [] operator instead of indexing into String::characters() directly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66286





--- Comment #22 from Xianzhu Wang <wangxianzhu at chromium.org>  2011-08-19 04:00:59 PST ---
I tried to create a big change which replaces most 'const UChar*' to StringIterator in WebKit to test the performance impact of additional condition check on each access, but gave up because of some bug introduced which is hard to find out from the hundreds of changed files.

I did a simpler test with my first patch that changes some characters() access to []. The results are as below:

                  patched           original
               avg    medium      avg    medium
url-parser   2339.35  2340.5    2270.75  2249.5
xml-parser   1417.4   1417.5    1429.75  1415
html-parser  1459.15  1457      1455.15  1454.5

Though my StringTest shows 1/2 cost increase for [] accesses, the impact seems not actually visible in real applications. I guess the impact of 8/16-bits implementation of String and StringIterator should be also like this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.