[Webkit-unassigned] [Bug 66477] [GTK] Html5 Notification, testing facilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66477





--- Comment #2 from Alexandre Mazari <scaroo at gmail.com>  2011-08-19 01:08:08 PST ---
(In reply to comment #1)
> Created an attachment (id=104357)
 --> (https://bugs.webkit.org/attachment.cgi?id=104357&action=review) [details]
> Patch

This patch add the required testing facilities to gtk DRT and LTC to pass notifications-related tests.
The passing tests are also unskipped.

The bulk of the code is located in Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk which from a conversation with mrobinson ain't really the right place.
The rationals behind this choice are:
- DRT and the javascript LTC api must both have access to the list of security requests and authorized orgins.
- the notifications testing code must be conditionally included by the preprocessor depending on the ENABLE(NOTIFICATIONS) macro value so to not break the compilation when notifications are disabled.

Sadly this macro is not working in Tools/ so I had to artificially move the code within the Source/WebKit/gtk tree.

I am not satisfied with this solution so any idea appreciated :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.