[Webkit-unassigned] [Bug 66522] Test how HTMLAnchorElement.getParameter reacts to too few arguments

Thu Aug 18 21:21:39 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=66522

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104440|review?                     |review+
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2011-08-18 21:21:39 PST ---
(From update of attachment 104440)
Looks fine. Two comments:

    1) It's probably better to have each test cover more than one function. A separate test for each function will bulk up the test directory and has few benefits.

    2) Using a separate script-tests source file is a bit of an anti-pattern. Alexey Proskuryakov has pointed out that you get almost all the same benefits if you put the script directly into the HTML file. You can still use the js-test files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.