[Webkit-unassigned] [Bug 66267] [chromium] Update scroll-mechanism from GestureRecognizer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 18 14:07:25 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66267


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-08-18 14:07:25 PST ---
Attachment 104394 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:81:  The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:278:  gesture_start is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:298:  gesture_end is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list