[Webkit-unassigned] [Bug 53438] Text-overflow is broken for button elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53438


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104334|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from Dave Hyatt <hyatt at apple.com>  2011-08-18 12:39:06 PST ---
(From update of attachment 104334)
View in context: https://bugs.webkit.org/attachment.cgi?id=104334&action=review

r-

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1222
> -    bool hasTextOverflow = style()->textOverflow() && hasOverflowClip();
> +    bool hasTextOverflow = style()->textOverflow();

I think you probably wanted this to be:

bool hasTextOverflow = style()->textOverflow() && (hasOverflowClip() || hasControlClip());

It's definitely incorrect to make text overflow apply when overflow is visible. I suspect this is just a case where the control clip needed to be considered as well since it's supposed to behave like overflow in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.