[Webkit-unassigned] [Bug 66258] ScrollAnimatorNone coasting implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66258





--- Comment #5 from James Robinson <jamesr at chromium.org>  2011-08-18 12:26:25 PST ---
(From update of attachment 104378)
View in context: https://bugs.webkit.org/attachment.cgi?id=104378&action=review

> Source/WebCore/platform/ScrollAnimatorNone.cpp:141
> +        double t1 = std::min(t, 1 / 2.75);

In WebKit, we prefer to put a 'using namespace std' at the top of the file and use the name unqualified.

Where are all of these magical numbers coming from?  Is it possible to give them useful symbolic names? They seem a little precise to be completely arbitrary.

> Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp:416
> +    for (double t = .25 ; t < 1 ; t += .25) {

nit: odd spacing here, i wouldn't expect a space before the ;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.