[Webkit-unassigned] [Bug 66361] Pass --makeargs of build-webkit to chromium linux builder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66361





--- Comment #3 from Xianzhu Wang <wangxianzhu at chromium.org>  2011-08-17 18:50:13 PST ---
(In reply to comment #2)
> (From update of attachment 104145 [details])
> Why?  Normally all args not understood by build-webkit are passed along to the build tool.
> 
> For example
> 
> build-webkit --various-xcode-arguments --another-xcode-arg WHATEVER_XCODE_ARG
> 
> is very common

Currently there are different ways to pass additional builder parameters for the buildXXX functions in webkitdirs.pm:

1. buildAutoToolsProject, buildQMakeProject, buildCMakeProjectOrExit use --makeargs to accept additional parameters to make, while pass other unknown parameters (and also --qmakeargs for buildQMakeProject) to configuration tools like autotools, qmake or cmake.

2. buildXCodeProject, buildWafProject directly pass unknown parameters to the build tool.

3. Other buildXXXs just ignore --makeargs or unknown parameters, like buildChromiumMakefile, buildChromiumVisualStudioProject, buildVisualStudioProject.

It seems reasonable to me to follow the convention of the 'make' family (above 1) for buildChromiumMakefile, because it also uses 'make'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.