[Webkit-unassigned] [Bug 65277] Make functions to find word boundaries more flexible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65277





--- Comment #40 from Van Lam <vanlam at google.com>  2011-08-17 16:34:13 PST ---
(In reply to comment #39)
> I have commented about function names above, and those comments still stand. This patch adds a good deal of confusion to an already confused area of code.

Hi Alexey,

I understand that the naming of right/leftWordPositionAcrossBoundary should change but thought that the renaming and several other stylistic to-dos would best be addressed in a separate cleanup patch.

I also understand that this isn't a clean patch. I've considered an alternative to implement this based on the observation:

You can chain calls to nextBoundary and previousBoundary to get the correct position. For example in the common case, you can get the next word break before word in LTR text by calling previousBoundary(nextBoundary(nextBoundary(currentVisiblePosition, nextWordPositionBoundary), nextWordPositionBoundary), previousWordPositionBoundary). While this avoids platform-level changes there are many cases to consider especially in bidi text and it is slower.

I'm open to ideas on how best to implement this functionality as it's blocking https://bugs.webkit.org/show_bug.cgi?id=65773.

Thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.