[Webkit-unassigned] [Bug 66145] [chromium] Assert that main thread and compositor thread are used safely

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66145





--- Comment #17 from Iain Merrick <husky at google.com>  2011-08-17 14:29:29 PST ---
(From update of attachment 104202)
View in context: https://bugs.webkit.org/attachment.cgi?id=104202&action=review

>> WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h:55
>> +    static bool isImplThread();
> 
> #ifndef NDEBUG around these?

Done.

>> WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h:63
>> +       WTF_MAKE_NONCOPYABLE(ScopedImplThread);
> 
> Do we really need this?  Why not just a setter?

Done.

>> WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:141
>> +}
> 
> It seems like in !USE(THREADED_COMPOSITOR) isMainThread() and isImplThread() will always return true.  That's not very useful - I think you want to check the fakeImplThread in the !USE(THREADED_COMPOSITOR) case.

I figured it had to return *something*, and true was safe (the main thread is actually the impl thread).

But if isImplThread isn't even defined for release builds, the problem goes away.

Done.

>> WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:155
>> +}
> 
> Do we really need to support arbitrary nesting here?  This seems overdesigned.  Just have setter for the bool.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.