[Webkit-unassigned] [Bug 66286] Use String [] operator instead of indexing into String::characters() directly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66286


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ggaren at apple.com




--- Comment #11 from Geoffrey Garen <ggaren at apple.com>  2011-08-17 12:14:04 PST ---
In the future, String::operator[] will do even more checking, to support 8bit vs 16bit representation, right? If so, the performance impact of repeated String::operator[] will be even greater.

If we need direct access to a character buffer for performance, maybe we should still allow it, but guard it with an ASSERT, e.g.:

if (string.is16Bit()) { // currently always true
    UChar* buffer = string.characters16(); // guarded by ASSERT
    ...
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.