[Webkit-unassigned] [Bug 66282] When changing the size of a menulist from x (x>1) to 1, the first item should be selected.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 07:17:19 PDT 2011


--- Comment #5 from Johnny(Jianning) Ding <jnd at chromium.org>  2011-08-16 07:17:19 PST ---
(From update of attachment 104034)
View in context: https://bugs.webkit.org/attachment.cgi?id=104034&action=review

> Source/WebCore/html/HTMLSelectElement.cpp:266
> +        if ((oldUsesMenuList != m_data.usesMenuList() || (!oldUsesMenuList && m_data.size() != oldSize)) && attached())

Current WebKit code assumes that menuList is always only used for select(size<=1 && !m_multiple), but looks like Android browser breaks this rule. So in the second condition, even the oldUsesMenuList is true (which means m_data.usesMenuList() is also true, but does not mean the size of select is 1), the Select's size still can be changed to value other than 1 and the change still requires to re-generate the renderer object (call method reattach)

What do you think?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list