[Webkit-unassigned] [Bug 66294] [WebSocket] Remove arguments from CloseEvent::create()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 05:56:49 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66294





--- Comment #2 from Yuta Kitamura <yutak at chromium.org>  2011-08-16 05:56:49 PST ---
(From update of attachment 104030)
View in context: https://bugs.webkit.org/attachment.cgi?id=104030&action=review

[Note: I'm not a WebKit reviewer]

Code change looks fine to me.

> Source/WebCore/ChangeLog:7
> +

You need to write the reason why you can safely omit wasClean argument from create().

You also need to justify not adding a new test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list