[Webkit-unassigned] [Bug 65839] CodeGenerator*.pm should support Web IDL Constructor attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65839





--- Comment #8 from Kentaro Hara <haraken at google.com>  2011-08-15 19:19:17 PST ---
(From update of attachment 103879)
View in context: https://bugs.webkit.org/attachment.cgi?id=103879&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1487
>> +        push(@implContent, <<END);
> 
> Maybe just use a string literal?

Done.

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1552
>> +sub IsContainValue
> 
> Just call it ContainsValue

Done.

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1558
>> +    my @valueList = split(/\|/, $orSeparatedValueString);
> 
> Does the | mean "either" or "and". Maybe | is not the best choice of separator?

Removed the separator, since the separator is not necessary any longer.

>> Source/WebCore/css/WebKitCSSMatrix.idl:34
>> +        ConstructorWith=CreateException|DOMObject
> 
> You don’t really need to do this | thing. You could have separate attributes like:
> 
> Constructor(…)
> ConstructWith=ScriptExecutionContext
> ConstructorSetsDOMWrapper
> ConstructorRaisesException
> 
> This is verbose, but it is clearer. Also, I think "DOMObject" might only apply to V8, not JSC (not sure) so we could make that one V8ConstructorSetsDOMWrapper.
> 
> Do you think that there are any constructors that have different attributes in these dimensions (eg one overload that throws exceptions and one that doesn’t?)

> Constructor(…)
> ConstructWith=ScriptExecutionContext
> ConstructorSetsDOMWrapper
> ConstructorRaisesException

Done. 

> Do you think that there are any constructors that have different attributes in these dimensions

I am not sure yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.