[Webkit-unassigned] [Bug 66229] WebKit doesn't react to device scale factor changes

Mon Aug 15 13:38:39 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=66229

--- Comment #8 from Adam Roben (:aroben) <aroben at apple.com>  2011-08-15 13:38:39 PST ---
(From update of attachment 103943)
View in context: https://bugs.webkit.org/attachment.cgi?id=103943&action=review

>> Source/WebKit/mac/WebView/WebView.mm:3395
>> +#endif
> 
> This should not be inside #ifdefs now, right?

Right! Removed.

>> Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.cpp:153
>> +void LayerTreeHostCA::deviceScaleFactorDidChange()
> 
> Seems odd to have methods called deviceScaleFactorChanged() and deviceScaleFactorDidChange() in various places. Can they share the same name?

In each case I was trying to match other functions in the same class (specifically, Frame::deviceOrPageScaleFactorChanged and related functions in RenderLayerCompositor and GraphicsLayer, and LayerTreeHost::sizeDidChange). I agree it would be nice if we had a consistent "did change" vs. "changed" convention throughout our code, particularly for cases like this where the two clash.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.