[Webkit-unassigned] [Bug 66248] New: Add adaptation macro for Windows CRT strftime() '#' extension and use in formatLocaleDate()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66248

           Summary: Add adaptation macro for Windows CRT strftime() '#'
                    extension and use in formatLocaleDate()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dbates at webkit.org
                CC: mrobinson at webkit.org


In function formatLocaleDate() in DataPrototype.cpp, we use the non-standard Windows CRT '#' extension for strftime() for the long date and time representation.

Currently, we don't use this non-standard extension when building for Symbian, and WinCE with Qt. The strftime() on QNX also doesn't support this extension and from what I can tell this extension is Microsoft-specific. Note, glibc does support the '#' extension for strftime() but it only switches the output between uppercase and lowercase characters, which is different from Microsoft's definition of '#'.

For completeness, Microsoft's definition of '#' is here, see the table that follows "As in the printf function, the # flag may prefix any formatting code...":
<http://msdn.microsoft.com/en-us/library/fe06s4ak(v=vs.80).aspx>

For Glibc, see section Glibc Notes of:
<http://linux.die.net/man/3/strftime>

We should consider defining a platform-adaptation macro for this non-standard extension, say HAVE_STRFTIME_WIN_HASH_FLAG, for platforms that support this extention (enabled for Windows only at the time of writing) instead of maintaining a list of OSes/configurations that don't support this extension.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.