[Webkit-unassigned] [Bug 66226] Chromium Mac: Rubber banding gutter drawing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66226





--- Comment #9 from Nico Weber <thakis at chromium.org>  2011-08-15 12:17:36 PST ---
(From update of attachment 103939)
View in context: https://bugs.webkit.org/attachment.cgi?id=103939&action=review

Looks pretty good overall!

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:684
> +    const unsigned kNumShadowColors = sizeof(kShadowColors)/sizeof(kShadowColors[0]);

WTF_ARRAY_LENGTH

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:712
> +            gradient = Gradient::create(FloatPoint(0, shadowRect.maxY()), FloatPoint(0, shadowRect.y()));

Is there any point in caching the gradients? (Do other client usually do this?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.