[Webkit-unassigned] [Bug 65834] NRWT should support cascading expectations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65834





--- Comment #9 from Tony Chang <tony at chromium.org>  2011-08-15 10:22:00 PST ---
(From update of attachment 103899)
View in context: https://bugs.webkit.org/attachment.cgi?id=103899&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:358
>> +            expectations += self._filesystem.read_text_file(path_to_wk2_test_expectations_file)
> 
> This might be more of a maintenance burden than you'd expect because test_expectations don't allow duplicate / shadowing expectations.  That means you'll need to make sure that you don't have conflicts between the two files.  (That's not to say we shouldn't go this route, just that it's not as pretty as it might seem.)

I thought overrides are allowed to duplicate/shadow (hence, it's an override).  That's what http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py#L825 seems to suggest and I think that's how the chromium repository test_expectations.txt works.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.