[Webkit-unassigned] [Bug 66226] Chromium Mac: Rubber banding gutter drawing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66226





--- Comment #2 from Sailesh Agrawal <sail at chromium.org>  2011-08-15 08:57:47 PST ---
(From update of attachment 103914)
View in context: https://bugs.webkit.org/attachment.cgi?id=103914&action=review

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:-77
> -    void preferencesChanged();

I think moving this up makes sense but it's probably better not to do these kind of changes until ScrollbarThemeChromiumMac.* and ScrollbarThemeMac.* are merged back together (hopefully soon).
Alternatively, you could make this change in both files.

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:202
> +                NSData* tiffData =  [image TIFFRepresentation];

I don't think this is a good way convert to CGImage. It's much better to create a CGBitmap and draw into it.

Also, if all you need to do is fill a rect with a patter than you don't even need a CGImage. You can use the NSImage directly. See LocalCurrentGraphicsContext.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.