[Webkit-unassigned] [Bug 66118] New: HANDLE_ANIMATION_INHERIT_AND_INITIAL macro fails to actually iterate.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 11 17:18:15 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66118

           Summary: HANDLE_ANIMATION_INHERIT_AND_INITIAL macro fails to
                    actually iterate.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: macpherson at chromium.org
                CC: darin at apple.com, mitz at webkit.org,
                    simon.fraser at apple.com, dino at apple.com


Noticed this during refactoring:

CSSStyleSelector.cpp:183    list->animation(0)->set##Prop(Animation::initialAnimation##Prop()); \
CSSStyleSelector.cpp:184    for (size_t i = 1; i < list->size(); ++i) \
CSSStyleSelector.cpp:185        list->animation(0)->clear##Prop(); \

As you can see, i is not used in the body of the loop, and instead the 0th element is set repeatedly, which also negates the effect of line 183.
Looks like this code has been in since 36634, and I don't know what user-visible bugs this causes, if any.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list